"Call-time pass-by-reference has been deprecated"

External Since: May 21, 2008 Posts: 12

Hello,

I am learning PHP5. I need to parse XML file and I found a solution in some
book on PHP5 ("PHP5 Programming" by Rasmus Lerdors and others).
Unfortunately I have two problems that I don't understand:

Warning: Call-time pass-by-reference has been deprecated; If you would like
to pass it by reference, modify the declaration of xml_set_object(). If you
would like to enable call-time pass-by-reference, you can set
allow_call_time_pass_reference to true in your INI file.
in /home/robert/public_html/rozgloszenia/bookparse.php on line 20
Parse error: syntax error, unexpected ';', expecting T_FUNCTION
in /home/robert/public_html/rozgloszenia/bookparse.php on line 100

<html>
<head>
<title>Moja biblioteczka</title>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<?php
class BookList
{
var $parser;
var $record;
var $current_field = '';
var $field_type;
var $ends_record;
var $records;

function BookList($filename)
{
$this->parser = xml_parser_create();
xml_set_object($this->parser, &$this); // HERE PROBLEM
xml_set_element_handler($this->parser, 'start_element', 'end_element');
xml_set_character_data_handler($this->parser, 'cdata');
$this->field_type = array('title' => 1,
'author' => 2,
'isbn' => 1,
'comment' => 1);
$this->ends_record = array('book' => true);
$x = join("", file($filename));
xml_parse($this->parser, $x);
xml_parser_free($this->parser);
}

function start_element($p, $element, &$attributes)
{
$element = strtolower($element);
if ($this->field_type[$element] != 0)
{
$this->current_field = $element;
}
else
{
$this->current_field = '';
}
}

function end_element($p, $element)
{
$element = strtolower($element);
if ($this->ends_record[$element])
{
$this->records[] = $this->record;
$this->record = array();
}
$this->current_field = '';
}

function cdata($p, $text)
{
if ($this->field_type[$this->current_field] === 2)
{
$this->record[$this->current_field][] = $text;
}
elseif ($this->field_type[$this->current_field] === 1)
{
$this->record[$this->current_field] .= $text;
}
}

function show_menu()
{
echo "<table border=1>\n";
foreach ($this->records as $book)
{
echo "<tr>";
$authors = join(', ', $book['author']);
printf("<th><a href='%s'>%s</a></th><td>%s</td></tr>\n",
$_SERVER['PHP_SELF'] . '?isbn=' . $book['isbn'],
$book['title'],
$authors);
echo "</tr>\n";
}

function show_book($isbn)
{
foreach ($this->records as $book)
{
if ($book['isbn'] !== $isbn)
{
continue;
}
$authors = join(', ', $book['author']);
printf("%s autor: %s. ", $book['title'], $authors);
printf("ISBN: %s ", $book['isbn']);
printf("Komentarz: %s\n", $book['comment']);
}
?>
Powrót do <a href="<?= $SERVER['PHP_SELF'] ?>">listy ksiÄ…Å¼ek</a>.
<?
}
}; // HERE PROBLEM

$my_library = new BookList("books.xml");
if ($_GET['isbn'])
{
$my_library->show_book($_GET['isbn']);
}
else
{
$my_library->show_menu();
}
</body>
</html>

Could you help me plase?
Thanks a lot!
/RAM/

External Since: Apr 24, 2008 Posts: 44

r_ahimsa_m.TakeThisOut@poczta.onet.pl wrote:
> Hello,
>
> I am learning PHP5. I need to parse XML file and I found a solution in some
> book on PHP5 ("PHP5 Programming" by Rasmus Lerdors and others).
> Unfortunately I have two problems that I don't understand:
>
> Warning: Call-time pass-by-reference has been deprecated; If you would like
> to pass it by reference, modify the declaration of xml_set_object(). If you
> would like to enable call-time pass-by-reference, you can set
> allow_call_time_pass_reference to true in your INI file.
> in /home/robert/public_html/rozgloszenia/bookparse.php on line 20
> Parse error: syntax error, unexpected ';', expecting T_FUNCTION
> in /home/robert/public_html/rozgloszenia/bookparse.php on line 100

> xml_set_object($this->parser, &$this); // HERE PROBLEM

Yup, just use xml_set_object($this->parser, $this);, the reference to
the second parameter rather then the value should be declared in the
funcion.

> }; // HERE PROBLEM

Braces ({}) for constructs like clasess, functions, and control
structures should bever end with ;

--
Rik Wasmus
....spamrun finished