SubRoutine Within Procedure: Good Practice?

I've never done it before, but the idea of including a subroutine that
is used only by a certain procedure within that procedure instead of
declaring it separately as a local procedure is starting to appeal to
me.

e.g. below. Pretend we are saving something called a "Security",
which has many child tables.
Also pretend that to process a child table we need to open some sort
of recordset and interate through it - same recordset for all child
tables.

Instead of declaring a separate Function to open said RecordSet and
return a pointer to it, we might just put the code in the using
procedure as below.

Seems like it adds a little bit to the ease of understanding in that
it's now obvious that nobody else uses that code.

It also seems to enhance readability by putting all the code in one
window.

But is it considered good practice?
----------------------------------------------------------------
Sub Security_Save(byVal theSecurityID As Long)
On Error GoTo Security_Save_Err

Dim myRS As DAO.RecordSet
Dim myQuery As DAO.QueryDef
Dim listCreated As Boolean

If mDirty_Security = True then
(do some stuff to save the Security record)
End If

If mDirty_ResetSchedule = True Then
If listCreated = False Then
createList
Else
myRS.MoveFirst
End If

(do some stuff the save changes to reset
schedule that uses the list
End If

If mDirty_PaymentSchedule = True Then
If listCreated = False Then
createList
Else
myRS.MoveFirst
End If

(do some stuff the save changes to Payment
schedule that uses the list)
End If


security_Save_xit:
On Error Resume Next
myQuery.Close
Set myQuery = Nothing
myRS.Close
set myRS = Nothing
Exit Sub

security_Save_err:
MsgBox: Error$,vbCritical, "Trouble In River City"
Resume Security_Save_xit

createList:
Set myQuery = CurrentDB.QueryDefs("qrySecurityList")
With myQuery
.Parameters("theSecurityID") = theSecurityID
Set myRS = .OpenRecordSet(dbOpenDynaSet)
End With
End Sub
----------------------------------------------------------------

On Oct 13, 10:07 am, "Dirk Goldgar"
<d... DeleteThis @NOdataSPAMgnostics.com.invalid> wrote:

> The problem is that, regardless of the merits or demerits of this technique,
> it doesn't work. That's not valid syntax.

So I found out at compile time when I tried to implement it.

Kind of embarassing to have posted such a dumb question - but I'd have
bet the mortgage money that I'd seen such coding at some time or
another.

Live and learn...

Thanks for the quick response.