how to move through records on a database.

External Since: Jan 31, 2005 Posts: 30

thanx. i will indent my code. when i copy and paste, the indentation gets
messed up.
i didnt know about the with thing, thanx for that.

i've done programming in java, and thats even harder.

thanx for all the help. i appreciate it.

dev Smile

"Randy Day" wrote in message

> Devin Panchal wrote:
>
  > > i clocked the delete button. its works well. this is waht i've got;
  > > Private Sub cmdDeleteRecord_Click()
  > > If Not rs.EOF Then
  > > rs.Delete
  > > MsgBox "You have deleted 1 record.", vbExclamation, "Database"
  > > rs.MoveFirst
  > > RefreshForm
  > > rs.Update
  > > End If
  > > End Sub
>
> Devin, I put this in as separate reply to let you
> get those other changes made and understood.
>
> I wanted to make some suggestions about programming
> style, especially indentation.
>
> You may have noticed I've sent you a few code snippets
> where some lines were indented. Indenting lines within
> a loop or IF statement is a commonly accepted (some might
> say 'expected') means of debugging code.
>
> It's surprising how often a visual cue such as the
> wrong indentation on a line will point out a coding
> error. I've included two copies of your Delete code
> below, both with errors introduced; see which one you
> spot quicker!
>
> Private Sub cmdDeleteRecord_Click()
> If Not rs.EOF Then
> rs.Delete
> MsgBox "You have deleted 1 record.", vbExclamation, "Database"
> rs.MoveFirst
> RefreshForm
> rs.Update
> End Sub
>
> Private Sub cmdDeleteRecord_Click()
> If Not rs.EOF Then
> rs.Delete
> MsgBox "You have deleted 1 record.", vbExclamation, "Database"
> rs.MoveFirst
> RefreshForm
> End If
> rs.Update
> End Sub
>
> It's normal to have multiple levels of indentation;
> notice below how the 'hierarchy' of the lines
> appears visually. Lines in the same loop appear at
> the same level of indentation:
>
> if v = 7 then
> for x = 1 to 9
> w = w + 1
> do while z < w
> rs.addnew
> rs.movelast
> rs.fields.item("Total") = x
> loop
> w = w + x
> next x
> rs.update
> end if
>
> In VB (and other languages) the TAB key is your
> friend!
>
> **************************************************
>
> The other thing you might find useful is the
> 'with' keyword. Here's your delete code again:
>
> Private Sub cmdDeleteRecord_Click()
> With rs
> If Not .EOF Then
> .Delete
> MsgBox "You have deleted 1 record.", vbExclamation, "Database"
> .MoveFirst
> RefreshForm
> .Update
> End If
> End with
> End Sub
>
> With a nice short recordset name like 'rs' it isn't
> so obvious, but imagine the savings in keystrokes
> if 'rs' was called 'rsMyRecordSetNumber1'.
>
> 'With' can be used with any object using the '.'
> separator: textboxes, comboboxes, recordsets, etc.

External Since: Feb 17, 2005 Posts: 2

Devin,

There is an autoindenter tool available for VB. You can get it at this web
page. I suspect you will find it is worth its weight in
common currency,

<a style='text-decoration: underline;' href="http://www.oaltd.co.uk/Indenter/Default.htm" target="_blank">http://www.oaltd.co.uk/Indenter/Default.htm</a>

Good luck,

Robert Berman

"Devin Panchal" wrote in message

> thanx. i will indent my code. when i copy and paste, the indentation gets
> messed up.
> i didnt know about the with thing, thanx for that.
>
> i've done programming in java, and thats even harder.
>
> thanx for all the help. i appreciate it.
>
> dev Smile

>

  >> Devin Panchal wrote:
  >>
   >> > i clocked the delete button. its works well. this is waht i've got;
   >> > Private Sub cmdDeleteRecord_Click()
   >> > If Not rs.EOF Then
   >> > rs.Delete
   >> > MsgBox "You have deleted 1 record.", vbExclamation, "Database"
   >> > rs.MoveFirst
   >> > RefreshForm
   >> > rs.Update
   >> > End If
   >> > End Sub
  >>
  >> Devin, I put this in as separate reply to let you
  >> get those other changes made and understood.
  >>
  >> I wanted to make some suggestions about programming
  >> style, especially indentation.
  >>
  >> You may have noticed I've sent you a few code snippets
  >> where some lines were indented. Indenting lines within
  >> a loop or IF statement is a commonly accepted (some might
  >> say 'expected') means of debugging code.
  >>
  >> It's surprising how often a visual cue such as the
  >> wrong indentation on a line will point out a coding
  >> error. I've included two copies of your Delete code
  >> below, both with errors introduced; see which one you
  >> spot quicker!
  >>
  >> Private Sub cmdDeleteRecord_Click()
  >> If Not rs.EOF Then
  >> rs.Delete
  >> MsgBox "You have deleted 1 record.", vbExclamation, "Database"
  >> rs.MoveFirst
  >> RefreshForm
  >> rs.Update
  >> End Sub
  >>
  >> Private Sub cmdDeleteRecord_Click()
  >> If Not rs.EOF Then
  >> rs.Delete
  >> MsgBox "You have deleted 1 record.", vbExclamation, "Database"
  >> rs.MoveFirst
  >> RefreshForm
  >> End If
  >> rs.Update
  >> End Sub
  >>
  >> It's normal to have multiple levels of indentation;
  >> notice below how the 'hierarchy' of the lines
  >> appears visually. Lines in the same loop appear at
  >> the same level of indentation:
  >>
  >> if v = 7 then
  >> for x = 1 to 9
  >> w = w + 1
  >> do while z < w
  >> rs.addnew
  >> rs.movelast
  >> rs.fields.item("Total") = x
  >> loop
  >> w = w + x
  >> next x
  >> rs.update
  >> end if
  >>
  >> In VB (and other languages) the TAB key is your
  >> friend!
  >>
  >> **************************************************
  >>
  >> The other thing you might find useful is the
  >> 'with' keyword. Here's your delete code again:
  >>
  >> Private Sub cmdDeleteRecord_Click()
  >> With rs
  >> If Not .EOF Then
  >> .Delete
  >> MsgBox "You have deleted 1 record.", vbExclamation, "Database"
  >> .MoveFirst
  >> RefreshForm
  >> .Update
  >> End If
  >> End with
  >> End Sub
  >>
  >> With a nice short recordset name like 'rs' it isn't
  >> so obvious, but imagine the savings in keystrokes
  >> if 'rs' was called 'rsMyRecordSetNumber1'.
  >>
  >> 'With' can be used with any object using the '.'
  >> separator: textboxes, comboboxes, recordsets, etc.
>
>